Skip to content

Comments

feat: add 'system' library format#11256

Merged
bluwy merged 1 commit intovitejs:mainfrom
tristanlins:main
May 29, 2024
Merged

feat: add 'system' library format#11256
bluwy merged 1 commit intovitejs:mainfrom
tristanlins:main

Conversation

@tristanlins
Copy link
Contributor

Description

Added system to the allowed library formats.
This allows to generate a SystemJS compatible library.

Additional context

SystemJS is a very popular module loader, and it's supported by rollup out of the box. We using SystemJS in our system. Currently I build an ES library with vite and then rebuild to system with rollup.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) feat: library mode labels May 18, 2024
@bluwy bluwy added this to the 5.3 milestone May 27, 2024
@bluwy bluwy merged commit 4102ca9 into vitejs:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: library mode p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants