Skip to content

feat(ssr)!: remove dedupe and mode support for CJS#11101

Merged
patak-cat merged 3 commits intomainfrom
remove-hook-node-resolve
Nov 28, 2022
Merged

feat(ssr)!: remove dedupe and mode support for CJS#11101
patak-cat merged 3 commits intomainfrom
remove-hook-node-resolve

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Nov 28, 2022

Description

reverts #3951

Remove hookNodeResolve and the ssrRequireHook plugin so there isn't a chance for Vite's custom node resolver to interfere in cases we don't want to. Followup to #10593

Additional context

I've hit this issue again at withastro/astro#5459, it would be nice to remove this in Vite 4.

We don't have tests that cover this feature.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change feat: ssr p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSR resolve always happens as require even when it's an import

3 participants