Skip to content

Comments

refactor: import version from rollup#10964

Merged
patak-dev merged 1 commit intovitejs:mainfrom
sapphi-red:refactor/import-version-from-rollup
Nov 17, 2022
Merged

refactor: import version from rollup#10964
patak-dev merged 1 commit intovitejs:mainfrom
sapphi-red:refactor/import-version-from-rollup

Conversation

@sapphi-red
Copy link
Member

Description

rollup exports VERSION variable. So changed to use that instead of reading package.json manually.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Nov 17, 2022
@patak-dev patak-dev merged commit 9f54c6a into vitejs:main Nov 17, 2022
@sapphi-red sapphi-red deleted the refactor/import-version-from-rollup branch November 17, 2022 09:46
fc pushed a commit to fc/vite that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants