Skip to content

Comments

fix: tsconfig jsx overrides esbuild options, reverts #10374#10714

Merged
patak-dev merged 1 commit intovitejs:mainfrom
sapphi-red:fix/esbuild-jsx
Oct 30, 2022
Merged

fix: tsconfig jsx overrides esbuild options, reverts #10374#10714
patak-dev merged 1 commit intovitejs:mainfrom
sapphi-red:fix/esbuild-jsx

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 30, 2022

Description

This PR reverts #10374.
That PR caused many breakage than I expected.

When tsconfig.json's jsx field has 'preserve' and esbuild.jsx: 'transform' in vite.config.js, 'preserve' is applied. (Previously 'transform' was applied.)
So tsconfig.json has precedence over esbuild options. This is similar to #10296.

I think we should revert this one and reintroduce this in Vite 4. (Maybe esbuild options should have precedence)

fixes #10670
fixes #10685
fixes #10702

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release labels Oct 30, 2022
@sapphi-red
Copy link
Member Author

sapphi-red commented Oct 30, 2022

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 30, 2022 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ❌ failure
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member

patak-dev commented Oct 30, 2022

The svelte error in ecosystem-ci is an unrelated type error, cc @bluwy

@patak-dev patak-dev merged commit aacf6a4 into vitejs:main Oct 30, 2022
@patak-dev
Copy link
Member

patak-dev commented Oct 30, 2022

Failed in main before this PR: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3355748797/jobs/5560255311
Works in 3.2.1: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3355816977/jobs/5560380496

@sapphi-red sapphi-red deleted the fix/esbuild-jsx branch October 31, 2022 11:38
@bluwy bluwy mentioned this pull request Nov 23, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees

No one assigned

Labels

p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tsx parse error when use latest vite & plugin JSX transform works in preview mode, but not in dev Respect my jsxRuntime configuration

2 participants

@sapphi-red @patak-dev