Description

fix #10255

Skip optional peer dep resolve when running the vite resolver through hookNodeResolve.

From the issue, technically it's impossible to have the optional peer dep resolved via hookNodeResolve, but there is a race condition that makes this happen that I can't minimize as a test case.

Additional context

I can't seem to replicate the test locally, so no tests added, but it is consistently reproducible with the issue repro.

I think we should remove hookNodeResolve in Vite 4. It has caused a lot of inconsistencies and bugs with features only working in CJS (which we're phasing out). I can try to attempt this in another PR.

I'd also like to backport this to v3

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.