in https://github.com/marko-js/vite/blob/main/src/__tests__/main.test.ts, this function shown below accepts a param server with a type http.Server.

async function testPage(dir: string, steps: Step[], server: http.Server) {

I don't think that will be a problem..

@PengBoUESTC Marko is failing here https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3295058377/jobs/5433215758, Http2SecureServer doesn't extends Server

@PengBoUESTC Marko is failing here https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3295058377/jobs/5433215758, Http2SecureServer doesn't extends Server

import type { Http2SecureServer } from 'node:http2'
http.Server
I think it means that http2.Http2SecureServer is not assignable to http.Server, that's correct,

in Marko-js/vite testPage function, the server parameter is declared as http.Server
async function testPage(dir: string, steps: Step[], server: http.Server) {

I think Marko-js/vite should update the server type when they want to update the vite version

I think Marko-js/vite should update the server type when they want to update the vite version

Yes, this is why we think it is better to move this PR to Vite 4. There weren't enough requests to justify having marko deal with this breaking change in their types in a minor version.

I think Marko-js/vite should update the server type when they want to update the vite version

Yes, this is why we think it is better to move this PR to Vite 4. There weren't enough requests to justify having marko deal with this breaking change in their types in a minor version.

Ok that maybe a better choice !