feat: update esbuild compilation affecting fields#10374
Merged
patak-dev merged 2 commits intovitejs:mainfrom Oct 14, 2022
Merged
feat: update esbuild compilation affecting fields#10374patak-dev merged 2 commits intovitejs:mainfrom
patak-dev merged 2 commits intovitejs:mainfrom
Conversation
sapphi-red
added
the
p2-nice-to-have
bluwy
approved these changes
Oct 14, 2022
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
Author
|
I think vitepress will be fixed by #10375. |
Member
Author
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
Author
|
It seems svelte and vite-plugin-ssr are failing with v3.2.0-beta.2 too. |
patak-dev
approved these changes
Oct 14, 2022
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Oct 30, 2022
This reverts commit f542727.
9 tasks
patak-dev
pushed a commit
that referenced
this pull request
Oct 30, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
alwaysStrict,jsx,jsxImportSourcefields when transpiling TS.https://esbuild.github.io/content-types/#tsconfig-json
jsx,jsxImportSourceis supported by evanw/esbuild#2349 that is supported from esbuild v0.14.51+.I'm not sure if we should include
alwaysStrict. Rollup will always output"use strict";unlessstrict: falseis set. (and ESM is always strict mode)Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).