Skip to content

fix: expose server as Http2SecureServer type#10196

Merged
patak-cat merged 8 commits intovitejs:mainfrom
PengBoUESTC:feature/http-server-type
Oct 20, 2022
Merged

fix: expose server as Http2SecureServer type#10196
patak-cat merged 8 commits intovitejs:mainfrom
PengBoUESTC:feature/http-server-type

Conversation

@PengBoUESTC
Copy link
Copy Markdown
Contributor

@PengBoUESTC PengBoUESTC commented Sep 22, 2022

Description

add Http2SecureServer type for vite server

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [] Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title chore: http server type fix: expose server as Http2SecureServer type Sep 23, 2022
patak-cat
patak-cat reviewed Oct 14, 2022
View reviewed changes
packages/vite/src/node/server/middlewares/compression.ts Outdated
let pendingListeners = []
let started = false
let size = 0
const { end, write, on, writeHead } = res
Copy link
Copy Markdown
Member

@patak-cat patak-cat Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated to the PR, would you revert it?

patak-cat
patak-cat reviewed Oct 14, 2022
View reviewed changes
@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented Oct 14, 2022

/ecosystem-ci run

@vite-ecosystem-ci
Copy link
Copy Markdown

vite-ecosystem-ci bot commented Oct 14, 2022 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ❌ failure
nuxt-framework ✅ success
rakkas ✅ success
svelte ✅ success
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ❌ failure
vitest ✅ success
windicss ✅ success

@PengBoUESTC PengBoUESTC requested a review from patak-cat October 14, 2022 09:51
@PengBoUESTC
Copy link
Copy Markdown
Contributor Author

PengBoUESTC commented Oct 19, 2022

Is there anything else to optimize? @patak-dev

@patak-cat patak-cat added this to the 3.2 milestone Oct 19, 2022
@patak-cat patak-cat added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 19, 2022
@patak-cat patak-cat merged commit f328f61 into vitejs:main Oct 20, 2022
@PengBoUESTC
Copy link
Copy Markdown
Contributor Author

PengBoUESTC commented Oct 20, 2022

Thanks! ^ _ ^

patak-cat added a commit that referenced this pull request Oct 21, 2022
@patak-cat
chore: revert #10196 until Vite 4
d2dd940 
This reverts commit f328f61.
@patak-cat patak-cat mentioned this pull request Oct 21, 2022
Merged
4 tasks
patak-cat added a commit that referenced this pull request Oct 21, 2022
@patak-cat
chore: revert #10196 until Vite 4 (#10574)
07c0336 
This reverts commit f328f61.
@PengBoUESTC PengBoUESTC deleted the feature/http-server-type branch January 11, 2023 02:10
@bluwy bluwy mentioned this pull request Nov 2, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

4 participants

@PengBoUESTC @patak-cat @sapphi-red @haoqunjiang