Skip to content

ws types incorrectly bundled #6073

@benmccann

Description

@benmccann

Describe the bug

SvelteKit is unable to be updated due to an issue with ws types. I'm not sure if it's the cause, but #5340 bundled the ws types, and #5540 bumped the ws version but did not update https://github.com/vitejs/vite/blob/main/packages/vite/types/ws.d.ts

Reproduction

git clone [email protected]:sveltejs/kit.git

Update the Vite version in packages/kit/package.json to 2.7.1. Then run:

pnpm install
pnpm check

System Info

Vite 2.7.1

Used Package Manager

pnpm

Logs

packages/kit check$ tsc && svelte-check --ignore "src/packaging/test"
│ ../../node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/index.d.ts(50,54): error TS7016: Could not find a declaration file for module 'ws'. '/home/bmccann/src/kit/node_modules/.pnpm/[email protected]/node_mod
│   Try `npm i --save-dev @types/ws` if it exists or add a new declaration (.d.ts) file containing `declare module 'ws';`
└─ Failed in 6.7s

Validations

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency filep3-downstream-blockerBlocking the downstream ecosystem to work properly (priority)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions