|
| 1 | +import nodePath from 'node:path' |
| 2 | +import type { RolldownOutput, OutputChunk } from 'rolldown' |
| 3 | +import { build } from 'vite' |
1 | 4 | import { expect, test } from 'vitest' |
2 | | -import { findAssetFile, isBuild, page } from '~utils' |
3 | | -import { port } from './serve' |
| 5 | +import { findAssetFile, isBuild, page, rootDir } from '~utils' |
| 6 | +import { port, serverLogs } from './serve' |
4 | 7 |
|
5 | 8 | const url = `http://localhost:${port}` |
6 | 9 |
|
@@ -30,12 +33,51 @@ test('supports nodejs_compat', async () => { |
30 | 33 | ) |
31 | 34 | }) |
32 | 35 |
|
| 36 | +test('supports requiring an external node builtin from CommonJS', async () => { |
| 37 | + await page.goto(url) |
| 38 | + expect(await page.textContent('.cjs-node-builtin')).toMatch( |
| 39 | + '[success] cjs node builtin require', |
| 40 | + ) |
| 41 | +}) |
| 42 | + |
| 43 | +test('warns when automatically externalizing a node builtin', () => { |
| 44 | + const logs = serverLogs.join('\n') |
| 45 | + expect(logs).toContain( |
| 46 | + 'Automatically externalized node built-in module "node:util"', |
| 47 | + ) |
| 48 | +}) |
| 49 | + |
33 | 50 | test.runIf(isBuild)('build output does not contain createRequire', async () => { |
34 | 51 | const workerContent = findAssetFile(/entry-worker/, 'worker', '') |
35 | 52 | expect(workerContent).toBeDefined() |
36 | 53 | expect(workerContent).not.toContain('createRequire') |
37 | 54 | }) |
38 | 55 |
|
| 56 | +test.runIf(isBuild)( |
| 57 | + 'converts a CommonJS require for an installed Node builtin package to an import', |
| 58 | + async () => { |
| 59 | + const output = (await build({ |
| 60 | + configFile: false, |
| 61 | + root: nodePath.join(rootDir, 'cjs-node-builtin'), |
| 62 | + logLevel: 'silent', |
| 63 | + ssr: { |
| 64 | + target: 'webworker', |
| 65 | + external: ['util'], |
| 66 | + }, |
| 67 | + build: { |
| 68 | + ssr: 'installed-node-builtin.cjs', |
| 69 | + write: false, |
| 70 | + }, |
| 71 | + })) as RolldownOutput |
| 72 | + const entry = output.output.find( |
| 73 | + (file): file is OutputChunk => file.type === 'chunk' && file.isEntry, |
| 74 | + ) |
| 75 | + |
| 76 | + expect(entry?.code).toContain('from "util"') |
| 77 | + expect(entry?.code).not.toContain('__require("util")') |
| 78 | + }, |
| 79 | +) |
| 80 | + |
39 | 81 | test.runIf(isBuild)('codeSplitting: false', () => { |
40 | 82 | const dynamicJsContent = findAssetFile(/dynamic-[-\w]+\.js/, 'worker') |
41 | 83 | expect(dynamicJsContent).toBeUndefined() |
|
0 commit comments