feat(types): use terser types from terser package (#20274)

sapphi-red · web-flow · commit a5799fa74c61 · 2025-06-24T10:31:39.000+09:00
diff --git a/eslint.config.js b/eslint.config.js
@@ -100,6 +100,7 @@ export default tseslint.config(
             'less',
             'sass',
             'sass-embedded',
+            'terser',
             'lightningcss',
             'vitest',
             'unbuild',
diff --git a/packages/vite/src/node/index.ts b/packages/vite/src/node/index.ts
@@ -252,7 +252,7 @@ export type { Connect } from 'dep-types/connect'
 export type { WebSocket, WebSocketAlias } from 'dep-types/ws'
 export type { HttpProxy } from 'dep-types/http-proxy'
 export type { FSWatcher, WatchOptions } from 'dep-types/chokidar'
-export type { Terser } from 'dep-types/terser'
+export type { Terser } from 'types/internal/terserOptions'
 export type { RollupCommonJSOptions } from 'dep-types/commonjs'
 export type { RollupDynamicImportVarsOptions } from 'dep-types/dynamicImportVars'
 export type { Matcher, AnymatchPattern, AnymatchFn } from 'dep-types/anymatch'
diff --git a/packages/vite/src/node/plugins/terser.ts b/packages/vite/src/node/plugins/terser.ts
@@ -1,10 +1,13 @@
-import type { Terser } from 'dep-types/terser'
+import type {
+  TerserMinifyOptions,
+  TerserMinifyOutput,
+} from 'types/internal/terserOptions'
 import { WorkerWithFallback } from 'artichokie'
 import type { Plugin } from '../plugin'
 import type { ResolvedConfig } from '..'
 import { requireResolveFromRootWithFallback } from '../utils'
 
-export interface TerserOptions extends Terser.MinifyOptions {
+export interface TerserOptions extends TerserMinifyOptions {
   /**
    * Vite-specific option to specify the max number of workers to spawn
    * when minifying files with terser.
@@ -42,12 +45,12 @@ export function terserPlugin(config: ResolvedConfig): Plugin {
         async (
           terserPath: string,
           code: string,
-          options: Terser.MinifyOptions,
+          options: TerserMinifyOptions,
         ) => {
           // test fails when using `import`. maybe related: https://github.com/nodejs/node/issues/43205
           // eslint-disable-next-line no-restricted-globals -- this function runs inside cjs
           const terser = require(terserPath)
-          return terser.minify(code, options) as Terser.MinifyOutput
+          return terser.minify(code, options) as TerserMinifyOutput
         },
       {
         shouldUseFake(_terserPath, _code, options) {
diff --git a/packages/vite/src/types/terser.d.ts b/packages/vite/src/types/terser.d.ts
diff --git a/packages/vite/types/internal/terserOptions.d.ts b/packages/vite/types/internal/terserOptions.d.ts
@@ -0,0 +1,11 @@
+/* eslint-disable @typescript-eslint/ban-ts-comment */
+
+// @ts-ignore `terser` may not be installed
+export type * as Terser from 'terser'
+// @ts-ignore `terser` may not be installed
+import type * as Terser from 'terser'
+
+/* eslint-enable @typescript-eslint/ban-ts-comment */
+
+export type TerserMinifyOptions = Terser.MinifyOptions
+export type TerserMinifyOutput = Terser.MinifyOutput
