fix(data-uri): only match ids starting with data: (#18241)

sapphi-red · sapphi-red · commit 96084d6e752c · 2024-10-14T19:24:29.000+09:00
diff --git a/packages/vite/src/node/plugins/dataUri.ts b/packages/vite/src/node/plugins/dataUri.ts
@@ -22,7 +22,7 @@ export function dataURIPlugin(): Plugin {
     },
 
     resolveId(id) {
-      if (!dataUriRE.test(id)) {
+      if (!id.trimStart().startsWith('data:')) {
         return
       }
 
diff --git a/playground/data-uri/index.html b/playground/data-uri/index.html
@@ -1,5 +1,6 @@
 <div class="plain"></div>
 <div class="base64"></div>
+<div class="comma"></div>
 
 <script type="module">
   import msg from "data:text/javascript, export default 'hi'"
@@ -8,6 +9,9 @@
   import base64Msg from 'data:text/javascript;base64, ZXhwb3J0IGRlZmF1bHQgJ2hpJw=='
   text('.base64', base64Msg)
 
+  import { comma } from 'comma/foo?number=1,2,3'
+  text('.comma', comma)
+
   function text(el, text) {
     document.querySelector(el).textContent = text
   }
diff --git a/playground/data-uri/vite.config.js b/playground/data-uri/vite.config.js
@@ -0,0 +1,20 @@
+import { defineConfig } from 'vite'
+
+export default defineConfig({
+  plugins: [
+    {
+      name: 'post-plugin',
+      enforce: 'post',
+      resolveId(id) {
+        if (id.replace(/\?.*$/, '') === 'comma/foo') {
+          return id
+        }
+      },
+      load(id) {
+        if (id.replace(/\?.*$/, '') === 'comma/foo') {
+          return `export const comma = 'hi'`
+        }
+      },
+    },
+  ],
+})

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ export function dataURIPlugin(): Plugin {`
`22`	`22`	`},`
`23`	`23`
`24`	`24`	`resolveId(id) {`
`25`		`- if (!dataUriRE.test(id)) {`
	`25`	`+ if (!id.trimStart().startsWith('data:')) {`
`26`	`26`	`return`
`27`	`27`	`}`
`28`	`28`