@@ -90,3 +90,72 @@ test('does not crash when a dep is discovered before the server starts listening
9090 await ssr . depsOptimizer ?. scanProcessing
9191 expect ( errors ) . toStrictEqual ( [ ] )
9292} )
93+
94+ // regression test for https://github.com/vitejs/vite/issues/23143
95+ // When a module importing a bare specifier is transformed through the JS API
96+ // before server.listen() is called, the dep is discovered and a pending warmup
97+ // request is issued for the optimized dep. That warmup waits on the dep's
98+ // processing promise, which is never resolved because depsOptimizer.init() has
99+ // not run. server.close() then waits forever for the pending warmup request.
100+ // The fix is for depsOptimizer.close() to resolve the processing promise so
101+ // in-flight requests can unblock during shutdown.
102+ test ( 'resolves discovered dep processing promise on close before init' , async ( ) => {
103+ const errors : string [ ] = [ ]
104+ const logger = createLogger ( 'error' )
105+ logger . error = ( msg ) => {
106+ errors . push ( typeof msg === 'string' ? msg : String ( msg ) )
107+ }
108+
109+ server = await createServer ( {
110+ configFile : false ,
111+ customLogger : logger ,
112+ root : path . join (
113+ import . meta. dirname ,
114+ '../fixtures/optimizer-discover-before-listen' ,
115+ ) ,
116+ cacheDir : 'node_modules/.vite-client-close' ,
117+ environments : {
118+ client : {
119+ dev : {
120+ preTransformRequests : false ,
121+ } ,
122+ optimizeDeps : {
123+ // ensure no cached metadata/file is reused so the dep is discovered
124+ // and its processing promise stays unresolved until close()
125+ force : true ,
126+ noDiscovery : false ,
127+ } ,
128+ } ,
129+ } ,
130+ } )
131+
132+ const client = server . environments . client
133+
134+ // Transform a module importing a bare specifier before the server is listening.
135+ // This discovers the dep and leaves its processing promise pending because
136+ // depsOptimizer.init() is deferred to listen().
137+ await client . transformRequest ( '/entry.js' )
138+
139+ const info = client . depsOptimizer ?. metadata . discovered ?. vue
140+ expect ( info ) . toBeDefined ( )
141+
142+ const processingPromise = info ! . processing ?. then ( ( ) => true )
143+
144+ // The dep's processing promise should still be pending at this point.
145+ const resolvedBeforeClose = await Promise . race ( [
146+ processingPromise ,
147+ setTimeout ( 500 , false ) ,
148+ ] )
149+ expect ( resolvedBeforeClose ) . toBe ( false )
150+
151+ // close() should resolve the processing promise so any in-flight or future
152+ // requests waiting on it (including server.close()) can unblock.
153+ await client . depsOptimizer ?. close ( )
154+
155+ const resolvedAfterClose = await Promise . race ( [
156+ processingPromise ,
157+ setTimeout ( 500 , false ) ,
158+ ] )
159+ expect ( resolvedAfterClose ) . toBe ( true )
160+ expect ( errors ) . toStrictEqual ( [ ] )
161+ } )
0 commit comments