refactor!: move side effect of restart server to the caller (#8746)

CHOYSEN · bluwy · web-flow · commit 521ca58d5d7c · 2023-10-26T15:12:29.000+08:00
Co-authored-by: bluwy &lt;bjornlu.dev@gmail.com&gt;
diff --git a/packages/vite/src/node/server/hmr.ts b/packages/vite/src/node/server/hmr.ts
@@ -18,6 +18,7 @@ import { getAffectedGlobModules } from '../plugins/importMetaGlob'
 import { isExplicitImportRequired } from '../plugins/importAnalysis'
 import { getEnvFilesForMode } from '../env'
 import type { ModuleNode } from './moduleGraph'
+import { restartServerWithUrls } from '.'
 
 export const debugHmr = createDebugger('vite:hmr')
 
@@ -77,7 +78,7 @@ export async function handleHMRUpdate(
       { clear: true, timestamp: true },
     )
     try {
-      await server.restart()
+      await restartServerWithUrls(server)
     } catch (e) {
       config.logger.error(colors.red(e))
     }
diff --git a/packages/vite/src/node/server/index.ts b/packages/vite/src/node/server/index.ts
@@ -863,9 +863,7 @@ export function resolveServerOptions(
 
 async function restartServer(server: ViteDevServer) {
   global.__vite_start_time = performance.now()
-  const { port: prevPort, host: prevHost } = server.config.server
   const shortcutsOptions = server._shortcutsOptions
-  const oldUrls = server.resolvedUrls
 
   let inlineConfig = server.config.inlineConfig
   if (server._forceOptimizeOnRestart) {
@@ -895,26 +893,47 @@ async function restartServer(server: ViteDevServer) {
 
   const {
     logger,
-    server: { port, host, middlewareMode },
+    server: { port, middlewareMode },
   } = server.config
   if (!middlewareMode) {
     await server.listen(port, true)
-    logger.info('server restarted.', { timestamp: true })
-    if (
-      (port ?? DEFAULT_DEV_PORT) !== (prevPort ?? DEFAULT_DEV_PORT) ||
-      host !== prevHost ||
-      diffDnsOrderChange(oldUrls, newServer.resolvedUrls)
-    ) {
-      logger.info('')
-      server.printUrls()
-    }
   } else {
     server.ws.listen()
-    logger.info('server restarted.', { timestamp: true })
   }
+  logger.info('server restarted.', { timestamp: true })
 
   if (shortcutsOptions) {
     shortcutsOptions.print = false
     bindCLIShortcuts(newServer, shortcutsOptions)
   }
 }
+
+/**
+ * Internal function to restart the Vite server and print URLs if changed
+ */
+export async function restartServerWithUrls(
+  server: ViteDevServer,
+): Promise<void> {
+  if (server.config.server.middlewareMode) {
+    await server.restart()
+    return
+  }
+
+  const { port: prevPort, host: prevHost } = server.config.server
+  const prevUrls = server.resolvedUrls
+
+  await server.restart()
+
+  const {
+    logger,
+    server: { port, host },
+  } = server.config
+  if (
+    (port ?? DEFAULT_DEV_PORT) !== (prevPort ?? DEFAULT_DEV_PORT) ||
+    host !== prevHost ||
+    diffDnsOrderChange(prevUrls, server.resolvedUrls)
+  ) {
+    logger.info('')
+    server.printUrls()
+  }
+}
diff --git a/packages/vite/src/node/shortcuts.ts b/packages/vite/src/node/shortcuts.ts
@@ -1,5 +1,6 @@
 import readline from 'node:readline'
 import colors from 'picocolors'
+import { restartServerWithUrls } from './server'
 import type { ViteDevServer } from './server'
 import type { PreviewServer } from './preview'
 import { openBrowser } from './server/openBrowser'
@@ -96,7 +97,7 @@ const BASE_DEV_SHORTCUTS: CLIShortcut<ViteDevServer>[] = [
     key: 'r',
     description: 'restart the server',
     async action(server) {
-      await server.restart()
+      await restartServerWithUrls(server)
     },
   },
   {

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ import { getAffectedGlobModules } from '../plugins/importMetaGlob'`
`18`	`18`	`import { isExplicitImportRequired } from '../plugins/importAnalysis'`
`19`	`19`	`import { getEnvFilesForMode } from '../env'`
`20`	`20`	`import type { ModuleNode } from './moduleGraph'`
	`21`	`+import { restartServerWithUrls } from '.'`
`21`	`22`
`22`	`23`	`export const debugHmr = createDebugger('vite:hmr')`
`23`	`24`
`@@ -77,7 +78,7 @@ export async function handleHMRUpdate(`
`77`	`78`	`{ clear: true, timestamp: true },`
`78`	`79`	`)`
`79`	`80`	`try {`
`80`		`- await server.restart()`
	`81`	`+ await restartServerWithUrls(server)`
`81`	`82`	`} catch (e) {`
`82`	`83`	`config.logger.error(colors.red(e))`
`83`	`84`	`}`