perf(utils): improve performance of numberToPos (#20244)

yuzheng14 · web-flow · commit 3f469012ad38 · 2025-06-20T12:50:57.000+08:00
diff --git a/packages/vite/src/node/__tests__/utils.spec.ts b/packages/vite/src/node/__tests__/utils.spec.ts
@@ -17,6 +17,7 @@ import {
   isFileReadable,
   mergeWithDefaults,
   normalizePath,
+  numberToPos,
   posToNumber,
   processSrcSetSync,
   resolveHostname,
@@ -245,6 +246,34 @@ describe('posToNumber', () => {
   })
 })
 
+describe('numberToPos', () => {
+  test('simple', () => {
+    const actual = numberToPos('a\nb', 2)
+    expect(actual).toEqual({ line: 2, column: 0 })
+  })
+  test('pass though pos', () => {
+    const actual = numberToPos('a\nb', { line: 2, column: 0 })
+    expect(actual).toEqual({ line: 2, column: 0 })
+  })
+  test('empty line', () => {
+    const actual = numberToPos('a\n\nb', 3)
+    expect(actual).toEqual({ line: 3, column: 0 })
+  })
+  test('middle of line', () => {
+    const actual = numberToPos('abc\ndef', 5)
+    expect(actual).toEqual({ line: 2, column: 1 })
+  })
+  test('end of line', () => {
+    const actual = numberToPos('abc\ndef', 3)
+    expect(actual).toEqual({ line: 1, column: 3 })
+  })
+  test('out of range', () => {
+    expect(() => numberToPos('a\nb', 5)).toThrowError(
+      'offset is longer than source length',
+    )
+  })
+})
+
 describe('generateCodeFrames', () => {
   const source = `
 import foo from './foo'
diff --git a/packages/vite/src/node/ssr/__tests__/__snapshots__/ssrLoadModule.spec.ts.snap b/packages/vite/src/node/ssr/__tests__/__snapshots__/ssrLoadModule.spec.ts.snap
@@ -26,12 +26,12 @@ exports[`parse error 2`] = `
 2  |  ",
   "id": "/fixtures/errors/syntax-error.js",
   "loc": {
-    "column": 9,
+    "column": 8,
     "file": "/fixtures/errors/syntax-error.js",
     "line": 1,
   },
   "message": "Parse failure: Expected ';', '}' or <eof>
-At file: /fixtures/errors/syntax-error.js:1:9",
+At file: /fixtures/errors/syntax-error.js:1:8",
 }
 `;
 
@@ -61,11 +61,11 @@ exports[`parse error 4`] = `
 2  |  ",
   "id": "/fixtures/errors/syntax-error.js",
   "loc": {
-    "column": 9,
+    "column": 8,
     "file": "/fixtures/errors/syntax-error.js",
     "line": 1,
   },
   "message": "Parse failure: Expected ';', '}' or <eof>
-At file: /fixtures/errors/syntax-error.js:1:9",
+At file: /fixtures/errors/syntax-error.js:1:8",
 }
 `;
diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts
@@ -493,19 +493,12 @@ export function numberToPos(source: string, offset: number | Pos): Pos {
       `offset is longer than source length! offset ${offset} > length ${source.length}`,
     )
   }
-  const lines = source.split(splitRE)
-  let counted = 0
-  let line = 0
-  let column = 0
-  for (; line < lines.length; line++) {
-    const lineLength = lines[line].length + 1
-    if (counted + lineLength >= offset) {
-      column = offset - counted + 1
-      break
-    }
-    counted += lineLength
+
+  const lines = source.slice(0, offset).split(splitRE)
+  return {
+    line: lines.length,
+    column: lines[lines.length - 1].length,
   }
-  return { line: line + 1, column }
 }
 
 export function generateCodeFrame(

Original file line number	Diff line number	Diff line change
`@@ -493,19 +493,12 @@ export function numberToPos(source: string, offset: number \| Pos): Pos {`
`493`	`493`	`offset is longer than source length! offset ${offset} > length ${source.length}`,
`494`	`494`	`)`
`495`	`495`	`}`
`496`		`- const lines = source.split(splitRE)`
`497`		`- let counted = 0`
`498`		`- let line = 0`
`499`		`- let column = 0`
`500`		`- for (; line < lines.length; line++) {`
`501`		`- const lineLength = lines[line].length + 1`
`502`		`- if (counted + lineLength >= offset) {`
`503`		`- column = offset - counted + 1`
`504`		`- break`
`505`		`- }`
`506`		`- counted += lineLength`
	`496`	`+`
	`497`	`+ const lines = source.slice(0, offset).split(splitRE)`
	`498`	`+ return {`
	`499`	`+ line: lines.length,`
	`500`	`+ column: lines[lines.length - 1].length,`
`507`	`501`	`}`
`508`		`- return { line: line + 1, column }`
`509`	`502`	`}`
`510`	`503`
`511`	`504`	`export function generateCodeFrame(`