fix(module-runner): normalize file:// on windows (#20449)

sheremet-va · web-flow · commit 1c9cb493f046 · 2025-07-22T12:24:08.000Z
diff --git a/packages/vite/src/module-runner/evaluatedModules.ts b/packages/vite/src/module-runner/evaluatedModules.ts
@@ -135,10 +135,9 @@ const prefixedBuiltins = new Set([
 // transform file url to id
 // virtual:custom -> virtual:custom
 // \0custom -> \0custom
-// /root/id -> /id
-// /root/id.js -> /id.js
-// C:/root/id.js -> /id.js
-// C:\root\id.js -> /id.js
+// node:fs -> fs
+// /@fs/C:/root/id.js => C:/root/id.js
+// file:///C:/root/id.js -> C:/root/id.js
 export function normalizeModuleId(file: string): string {
   if (prefixedBuiltins.has(file)) return file
 
@@ -149,5 +148,5 @@ export function normalizeModuleId(file: string): string {
     .replace(/^\/+/, '/')
 
   // if it's not in the root, keep it as a path, not a URL
-  return unixFile.replace(/^file:\//, '/')
+  return unixFile.replace(/^file:\/+/, isWindows ? '' : '/')
 }
diff --git a/packages/vite/src/node/ssr/runtime/__tests__/fixtures/import-external.ts b/packages/vite/src/node/ssr/runtime/__tests__/fixtures/import-external.ts
@@ -0,0 +1 @@
+import 'tinyglobby'
diff --git a/packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts b/packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts
@@ -3,12 +3,17 @@ import { posix, win32 } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { describe, expect, vi } from 'vitest'
 import { isWindows } from '../../../../shared/utils'
+import type { ExternalFetchResult } from '../../../../shared/invokeMethods'
 import { createModuleRunnerTester } from './utils'
 
 const _URL = URL
 
 describe('module runner initialization', async () => {
-  const it = await createModuleRunnerTester()
+  const it = await createModuleRunnerTester({
+    resolve: {
+      external: ['tinyglobby'],
+    },
+  })
 
   it('correctly runs ssr code', async ({ runner }) => {
     const mod = await runner.import('/fixtures/simple.js')
@@ -489,4 +494,24 @@ describe('virtual module hmr', async () => {
       expect(mod?.exports.default).toBe('reloaded')
     })
   })
+
+  it("the external module's ID and file are resolved correctly", async ({
+    server,
+    runner,
+  }) => {
+    await runner.import(
+      posix.join(server.config.root, 'fixtures/import-external.ts'),
+    )
+    const moduleNode = runner.evaluatedModules.getModuleByUrl('tinyglobby')!
+    const meta = moduleNode.meta as ExternalFetchResult
+    if (process.platform === 'win32') {
+      expect(meta.externalize).toMatch(/^file:\/\/\/\w:\//) // file:///C:/
+      expect(moduleNode.id).toMatch(/^\w:\//) // C:/
+      expect(moduleNode.file).toMatch(/^\w:\//) // C:/
+    } else {
+      expect(meta.externalize).toMatch(/^file:\/\/\//) // file:///
+      expect(moduleNode.id).toMatch(/^\//) // /
+      expect(moduleNode.file).toMatch(/^\//) // /
+    }
+  })
 })
