Skip to content

Comments

wip: use dev api#401

Merged
sapphi-red merged 11 commits intofeat/full-bundle-dev-envfrom
feat/full-bundle-dev-env-dev-api
Sep 24, 2025
Merged

wip: use dev api#401
sapphi-red merged 11 commits intofeat/full-bundle-dev-envfrom
feat/full-bundle-dev-env-dev-api

Conversation

@sapphi-red
Copy link
Member

Description

}
if (
fullBundleEnv.triggerBundleRegenerationIfStale() ||
(await fullBundleEnv.triggerBundleRegenerationIfStale()) ||
Copy link

@hyf0 hyf0 Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference compared to use DevEngine#ensureLatestBuild?

Copy link
Member Author

@sapphi-red sapphi-red Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduleBuildIfStale returns whether we have the latest build or not.

graphite-app bot pushed a commit to rolldown/rolldown that referenced this pull request Sep 9, 2025
Added the change files in `onHmrUpdates` callback for logging.

refs vitejs/rolldown-vite#401
graphite-app bot pushed a commit to rolldown/rolldown that referenced this pull request Sep 9, 2025
Added `scheduleBuildIfStale` method to DevEngine to know whether the build is triggered.

refs vitejs/rolldown-vite#401
graphite-app bot pushed a commit to rolldown/rolldown that referenced this pull request Sep 9, 2025
Added the change files in `onHmrUpdates` callback for logging.

refs vitejs/rolldown-vite#401
graphite-app bot pushed a commit to rolldown/rolldown that referenced this pull request Sep 9, 2025
Added `scheduleBuildIfStale` method to DevEngine to know whether the build is triggered.

refs vitejs/rolldown-vite#401
hyf0 pushed a commit to rolldown/rolldown that referenced this pull request Sep 9, 2025
Added `scheduleBuildIfStale` method to DevEngine to know whether the
build is triggered.

refs vitejs/rolldown-vite#401
sapphi-red added a commit to rolldown/rolldown that referenced this pull request Sep 10, 2025
graphite-app bot pushed a commit to rolldown/rolldown that referenced this pull request Sep 10, 2025
graphite-app bot pushed a commit to rolldown/rolldown that referenced this pull request Sep 10, 2025
@sapphi-red sapphi-red force-pushed the feat/full-bundle-dev-env branch from ee97dcd to b7efbbf Compare September 11, 2025 03:12
@sapphi-red sapphi-red force-pushed the feat/full-bundle-dev-env-dev-api branch 2 times, most recently from 04d598a to 76de4bd Compare September 11, 2025 05:57
@sapphi-red sapphi-red force-pushed the feat/full-bundle-dev-env branch from ddc6aba to 50b0a60 Compare September 16, 2025 05:28
@sapphi-red sapphi-red force-pushed the feat/full-bundle-dev-env-dev-api branch from 8fcfa84 to 56fe632 Compare September 16, 2025 05:28
@sapphi-red sapphi-red force-pushed the feat/full-bundle-dev-env-dev-api branch from 56fe632 to 9d4b71a Compare September 16, 2025 05:48
@sapphi-red sapphi-red marked this pull request as ready for review September 24, 2025 06:05
@sapphi-red sapphi-red merged commit 8edf64b into feat/full-bundle-dev-env Sep 24, 2025
3 of 22 checks passed
@sapphi-red sapphi-red deleted the feat/full-bundle-dev-env-dev-api branch September 24, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants