fix: merge tsconfig jsx options even when oxc.jsx.runtime is set #376
Merged
sapphi-red merged 1 commit intovitejs:rolldown-vitefrom Aug 18, 2025
Merged
Conversation
commit: |
hi-ogawa
changed the title
oxc.jsx.runtime = "automatic"oxc.jsx.runtime = "automatic"
hi-ogawa
added a commit
to vitejs/vite-plugin-react
that referenced
this pull request
Aug 18, 2025
Author
|
|
sapphi-red
approved these changes
Aug 18, 2025
Member
|
@hi-ogawa Are you going to create a PR to the native plugin? |
Author
|
Yes, I'll port the change to native plugin. |
hi-ogawa
changed the title
oxc.jsx.runtime = "automatic"
hi-ogawa
changed the title
oxc.jsx.runtime is set
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Aug 18, 2025
…`oxc.jsx.runtime` is set (#5771) This PR ports vitejs/rolldown-vite#376 to builtin transform plugin to fix vitejs/vite-plugin-react#726
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Aug 18, 2025
…`oxc.jsx.runtime` is set (#5771) This PR ports vitejs/rolldown-vite#376 to builtin transform plugin to fix_ vitejs/vite-plugin-react#726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related vitejs/vite-plugin-react#726
This change is necessary to support following two cases: