refactor: use descriptive namespace for json-render state key#246
Merged
Conversation
Use `devtoolskit:internal:json-render:<id>` instead of the cryptic `__jr:<id>` for shared state keys. Improves clarity and prevents accidental namespace collisions. Co-Authored-By: Claude Haiku 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the internal shared state key for json-render from the cryptic
__jr:<id>to a more descriptive and properly namespaceddevtoolskit:internal:json-render:<id>. This improves code clarity and reduces the risk of accidental namespace collisions with other internal state keys.Linked Issues
None
Additional context
No breaking changes — the key is only constructed in one place and dynamically read by clients via
_stateKey.