fix(core): support IPv6 in devtools server link#204
Merged
webfansplz merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the displayed DevTools server URL when binding to an IPv6 host by formatting IPv6 literals correctly (bracketed), closing #202.
Changes:
- Added a small URL formatting helper to normalize
host+portinto a valid HTTP URL (including IPv6 bracket wrapping). - Updated the CLI “started at” log and
--openbehavior to use the normalized URL. - Added Vitest coverage for the new normalization behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/node/utils.ts | Introduces normalizeHttpHost to format IPv6 hosts into valid bracketed HTTP URLs. |
| packages/core/src/node/cli-commands.ts | Uses the helper for the logged/opened DevTools URL. |
| packages/core/src/node/tests/utils.test.ts | Adds tests validating IPv4 localhost mapping, IPv6 bracketing, and non-IP preservation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #202