Repository navigation
fix: avoid duplicate async authentication calls - #1755
Merged
vitalik merged 1 commit intoSep 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The synchronous authentication path called an async-marked callback once to inspect its return value. When that value was a coroutine, it discarded the coroutine and invoked the callback a second time through
async_to_sync. This duplicated synchronous work in__call__and emitted both an un-awaited coroutine warning and anasync_to_syncwarning.The fix bridges the coroutine returned by the first invocation instead of invoking the callback again.
Fixes #1751.
Validation
.venv/bin/pytest -q tests/test_auth_async.py— 8 passed.venv/bin/pytest -q tests/test_auth.py— 34 passed.venv/bin/ruff format --check ninja/operation.py tests/test_auth_async.py.venv/bin/ruff check ninja/operation.py tests/test_auth_async.py.venv/bin/mypy ninja/operation.py