You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The performance issue in #71 is due to the layout cache being constantly invalidated.
It is solved by having a separate cache for the recursive call in section "3. Determine the flex base size and hypothetical main size of each item"
This fix makes one test fail (but it makes sense, each cache measure once):
failures:
---- measure::only_measure_once stdout ----
thread 'measure::only_measure_once' panicked at 'assertion failed: `(left == right)`
left: `2`,
right: `1`', tests/measure.rs:564:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Running the example code from #71 in debug mode gives:
While this PR fixes one issue with cache invalidation, there is still another issue causing exponential recursion.
I'll detail it here since I haven't been able to solve it yet.
The culprit seems to be the recursive call in the "Cross Size Determination". While experimenting on forcing the use of cached results, it reduced the number of recursion by 4 orders of magnitude (15'207'071 to 1'560 to be precise) in a test with about 20 nested containers. But doing that broke the cross size in fit-content mode (you can see it in this branch: https://github.com/Davier/stretch/commits/wip).
I'm sure there is a way to solve that issue, but it may need more than my basic understanding of the algorithm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance issue in #71 is due to the layout cache being constantly invalidated.
It is solved by having a separate cache for the recursive call in section "3. Determine the flex base size and hypothetical main size of each item"
This fix makes one test fail (but it makes sense, each cache measure once):
Running the example code from #71 in debug mode gives:
and in release:
The exponential behaviour is clearly gone, and the measured time saturates since most caches from the previous iterations are reused.