Adding file path for nerdctl and finch#87
Conversation
|
Also wanted to check a couple of things
|
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
it seems fine to me to add nerdctl/finch, but I'm curious... can you please explain your use case?
Re: your other questions--they're good/valid questions, but should be discussed as distinct issues with dedicated threads, not as a distraction from the code change in this PR.
Thanks!
go.mod
Outdated
| module github.com/vishvananda/netns | ||
|
|
||
| go 1.17 | ||
| go 1.22 |
There was a problem hiding this comment.
This should go in a separate PR as it's orthogonal to the primary intent of the PR. Also, please don't bump the go version... it means different things in the context of a library than it does in your app.
There was a problem hiding this comment.
ack will remove this
nerdctl uses this package for netns, for finch one of our customer requested it for their systems which uses nerdctl to create a container and have a custom network namespace the container connects to. |
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
|
moved the other questions to issues. |
|
LGTM... longterm it seems weird to have hardcoded paths in here rather than an interface that the user can override a set of defaults, but for now it's fine I think... it's not like this list is growing exponentially! |
|
@jeffwidman Will it be possible to release a 0.5.0 for this commit, tagging it to a version seems easier to pull and use. |
| // Support for nerdctl | ||
| filepath.Join(cgroupRoot, "system.slice", "nerdctl-"+id+".scope", pidFile), | ||
| // Support for finch | ||
| filepath.Join(cgroupRoot, "..", "systemd", "finch", id, pidFile), |
There was a problem hiding this comment.
@AkihiroSuda
AL2 machines are using cgroupfs, their cgroup is set to cgroup v1.
dev-dsk-shubhum-2b-5b633f8c % sudo nerdctl info
Client:
Namespace: default
Debug Mode: false
Server:
Server Version: 1.7.25
Storage Driver: overlayfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Cgroup Version: 1
Plugins:
Log: fluentd journald json-file none syslog
Storage: native overlayfs soci
Security Options:
seccomp
Profile: builtin
Kernel Version: 5.10.233-203.887.amzn2int.x86_64
Operating System: Amazon Linux 2
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 15.26GiB
Name: dev-dsk-shubhum-2b-5b633f8c.us-west-2.amazon.com
ID: c9a0db03-7d44-421e-b75a-14eef9237a23
3 participants
Adding the paths for pidfile for enabling usage with nerdctl and finch.