ci(lint): enable errcheck, errorlint, gci, misspell, nonamedreturns and staticcheck linters#71
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
changed the title
Signed-off-by: Matthieu MOREL <[email protected]>
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
👍 for this change.
Had one qq... also, be great to add some really useful ones like revive, although that should probably land in a later PR to keep the scope of this one straightforward.
mmorel-35
changed the title
mmorel-35
force-pushed
the
errorlint
branch
2 times, most recently
from
f089a27 to
e986c62
Compare
mmorel-35
changed the title
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
👍 overall, a few small comments
| return -1, ErrNotImplemented | ||
| } | ||
|
|
||
| func NewNamed(name string) (NsHandle, error) { |
There was a problem hiding this comment.
In general I prefer the _ convention, however sometimes for primitive types, keeping the arg name is helpful... for example here I'd rather keep this one because even though unused, it clarifies to the caller what the arg is intended for. That way if we do ever implement it, callers are already ready for it.
Same with all the rest of the following args in this file...
Can you please add a per-line exception?
nshandle_linux.go
Outdated
| // UniqueID returns a string which uniquely identifies the namespace | ||
| // associated with the network handle. | ||
| func (ns NsHandle) UniqueId() string { | ||
| func (ns NsHandle) UniqueID() string { |
There was a problem hiding this comment.
This is a breaking change is it not?
In general I don't mind breaking changes like this where the type checker will complain, but we'd need to ensure to bump the major version.
And also, I do wonder, is it really worth it to make a breaking change purely for a cosmetic lint?
Signed-off-by: Matthieu MOREL <[email protected]> up Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
changed the title
Signed-off-by: Matthieu MOREL <[email protected]>
|
Your two comments are against revive's rules. |
Yes, I'm aware, that's why I mentioned adding specific exceptions for violations.
Sounds fine. Thanks for contributing this PR! |
2 participants
Signed-off-by: Matthieu MOREL [email protected]