ci(lint): setup YAML Lint step#68
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
changed the title
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
Had one question... I personally tend to prefer some of these comments as inline, since they're distracting to folks who know what these params do, but helpful to provide more info for those who don't and need a little more hints.
Also, curious what prompted you to do this? It's nice, but we don't have that much yaml in here... was your editor yelling at you about it?
| go mod tidy | ||
| git diff --exit-code | ||
| - name: Test | ||
| run: go test -exec "sudo -n" -v ./... |
There was a problem hiding this comment.
these formatting changes are all nice improvements 👍
|
Can you squash your commits? |
I'll do that when I can access a computer, within two days |
|
No worries, I can just squash when merging. Also, in the future, if you don't have a computer where you can locally I only recently discovered them myself, and while I still prefer more advanced coding on my local laptop, for quick changes, esp git commit changes, the codespaces are incredibly convenient. |
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
Thanks again for this!
2 participants
Signed-off-by: Matthieu MOREL [email protected]