Skip to content

Comments

Fixed the k8s docker netns detection err when pod QOS is Guaranteed#45

Closed
marviniter wants to merge 1 commit intovishvananda:masterfrom
marviniter:fix-k8s-netns-detection-err
Closed

Fixed the k8s docker netns detection err when pod QOS is Guaranteed#45
marviniter wants to merge 1 commit intovishvananda:masterfrom
marviniter:fix-k8s-netns-detection-err

Conversation

@marviniter
Copy link

@marviniter marviniter commented Dec 15, 2020

With k8s 1.14.6 and docker 18.09.9, the docker netns detection
funtion failed to look for the Pod's container task file when Pod QOS is Guaranteed. This
change fixed the issue.
When the QOS is Guaranteed the cgroup under cgroup/systemd/kubepods/pod* not under cgroup/systemd/kubepods/{besteffort,burstable}/pod*

@imilchev
Copy link
Contributor

imilchev commented Dec 28, 2020

For nodes that are not using systemd your fix will not work. I opened a PR that fixes all cases. See #47

@aboch
Copy link
Collaborator

aboch commented Dec 30, 2020

superseded by #47

@aboch aboch closed this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants