Use golang.org/x/sys/unix instead of syscall#40
Merged
vishvananda merged 1 commit intovishvananda:masterfrom May 20, 2020
Merged
Use golang.org/x/sys/unix instead of syscall#40vishvananda merged 1 commit intovishvananda:masterfrom
vishvananda merged 1 commit intovishvananda:masterfrom
Conversation
The syscall package is deprecated and no longer updated as per https://golang.org/pkg/syscall/. Use the golang.org/x/sys/unix package instead, which also provides a wrapper for SYS_SETNS, so the syscall number encoding depending on runtime.GOARCH can be dropped. Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
use-x-sys-unix
branch
from
24dbec2 to
20c1755
Compare
Contributor
Author
|
@vishvananda @aboch friendly ping: Is there anything preventing this from being merged? |
Collaborator
|
LGTM |
ethanspitz
approved these changes
May 20, 2020
ethanspitz
left a comment
ethanspitz
left a comment
There was a problem hiding this comment.
Looks good! I just filed a bug for this :)
vishvananda
pushed a commit
that referenced
this pull request
Sep 13, 2022
This completes the migration from `syscall` --> `golang.org/x/sys/unix` which was started in #40: > The syscall package is deprecated and no longer updated as per https://golang.org/pkg/syscall/. Use the golang.org/x/sys/unix package instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The syscall package is deprecated and no longer updated as per
https://golang.org/pkg/syscall/. Use the golang.org/x/sys/unix package
instead, which also provides a wrapper for
SYS_SETNS, so the syscallnumber encoding depending on
runtime.GOARCHcan be dropped.Signed-off-by: Tobias Klauser [email protected]