Skip to content

Comments

Add support for Go modules#35

Merged
vishvananda merged 1 commit intovishvananda:masterfrom
tklauser:go-mod
Nov 6, 2019
Merged

Add support for Go modules#35
vishvananda merged 1 commit intovishvananda:masterfrom
tklauser:go-mod

Conversation

@tklauser
Copy link
Contributor

@tklauser tklauser commented Jun 7, 2019

Signed-off-by: Tobias Klauser [email protected]

Signed-off-by: Tobias Klauser <[email protected]>
@vishvananda
Copy link
Owner

This seems reasonable to me, but I'm not sure if this will affect anyone using this in older projects.

@tklauser
Copy link
Contributor Author

tklauser commented Jun 26, 2019

This shouldn't affect anyone using it on older projects without modules (or with Go versions that don't have module support enabled). They can still use it as before.

@tklauser
Copy link
Contributor Author

tklauser commented Nov 6, 2019

Ping?

@aboch
Copy link
Collaborator

aboch commented Nov 6, 2019

LGTM

@vishvananda vishvananda merged commit 0a2b9b5 into vishvananda:master Nov 6, 2019
@tklauser tklauser deleted the go-mod branch November 6, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants