add ns support mips64le arch#32
Merged
vishvananda merged 1 commit intovishvananda:masterfrom Jun 25, 2019
Merged
Conversation
go env info [root@node152 weaver]# go env GOARCH="mips64le" GOBIN="" GOCACHE="/root/.cache/go-build" GOEXE="" GOHOSTARCH="mips64le" GOHOSTOS="linux" GOOS="linux" GOPATH="/root/goworkspace" GORACE="" GOROOT="/home/longxin/workspace/go" GOTMPDIR="" GOTOOLDIR="/home/longxin/workspace/go/pkg/tool/linux_mips64le" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -mabi=64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build929428261=/tmp/go-build -gno-record-gcc-switches"
tklauser
reviewed
Jun 7, 2019
Contributor
tklauser
left a comment
tklauser
left a comment
There was a problem hiding this comment.
Alternatively, SYS_NETNS from golang.org/x/sys/unix (which is already a dependency) could be used to replace this, i.e.
import "golang.org/x/sys/unix"
...
var SYS_SETNS = unix.SYS_SETNS
Contributor
Author
|
@tklauser ,yes,but so many go projects use vishvananda/netns, maybe this is useful to add mips64le in this project |
Contributor
|
@davidstack using |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go env info
[root@node152 weaver]# go env
GOARCH="mips64le"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOHOSTARCH="mips64le"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/root/goworkspace"
GORACE=""
GOROOT="/home/longxin/workspace/go"
GOTMPDIR=""
GOTOOLDIR="/home/longxin/workspace/go/pkg/tool/linux_mips64le"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -mabi=64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build929428261=/tmp/go-build -gno-record-gcc-switches"