Skip to content

Comments

In contaner path fix#29

Merged
vishvananda merged 1 commit intovishvananda:masterfrom
sbezverk:in_container_path
Jul 20, 2018
Merged

In contaner path fix#29
vishvananda merged 1 commit intovishvananda:masterfrom
sbezverk:in_container_path

Conversation

@sbezverk
Copy link
Contributor

When the process attempting to get namespace by using GetFromDocker, running in Docker container, the path to the list of containers is:
groupRoot, "kubepods.slice", "kubepods-besteffort.slice", "*", "docker-"+id+".scope", "tasks"

Signed-off-by: Serguei Bezverkhi [email protected]

Signed-off-by: Serguei Bezverkhi <[email protected]>
@vishvananda
Copy link
Owner

should this replace the previous addition? or are there cases where the other path (including cgroupThis) is also correct?

@sbezverk
Copy link
Contributor Author

sbezverk commented Jul 20, 2018

@vishvananda we need both, first addresses when process runs as a normal process, second when it runs from a docket container.

@vishvananda
Copy link
Owner

great thanks merging

@vishvananda vishvananda merged commit 13995c7 into vishvananda:master Jul 20, 2018
@sbezverk
Copy link
Contributor Author

@vishvananda thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants