Add "default" dst while no DST attr responsed from nl#852
Merged
aboch merged 1 commit intovishvananda:mainfrom Jun 4, 2023
Merged
Add "default" dst while no DST attr responsed from nl#852aboch merged 1 commit intovishvananda:mainfrom
aboch merged 1 commit intovishvananda:mainfrom
Conversation
PlatformLC
force-pushed
the
default_route
branch
from
3bf36ad to
dd613b7
Compare
Contributor
Author
|
@vishvananda Would you have a look at this? |
Collaborator
|
@PlatformLC Please squash your two commits into one. |
Owner
|
this looks good, if you squash as @aboch requested we can merge it. |
Signed-off-by: Li Chun <[email protected]>
Contributor
Author
Updated. PTAL |
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 4, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 4, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 5, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 5, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 7, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 7, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 7, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 7, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 7, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 8, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 8, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 8, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 9, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 10, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 10, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 10, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 10, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 11, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 13, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 13, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 16, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 16, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 16, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 16, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 16, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit 4400ad54d0bc4e95f0e5e2a09d91795510e1c3f2)
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Aug 16, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 16, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit cc0de3c)
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Aug 17, 2023
Refactor route manager to reflect it is now its own pkg and should be renamed. Netlink library represents a dst with CIDR '0.0.0.0/0', aka 'blackhole' route as dst = nil, therefore we must work around this. This should be fixed with PR: vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit cc0de3c)
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Nov 13, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Nov 18, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Nov 26, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Dec 3, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Dec 6, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Dec 6, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Dec 6, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Dec 8, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Dec 18, 2023
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Jan 2, 2024
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Jan 9, 2024
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Jan 14, 2024
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Jan 29, 2024
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes-1
that referenced
this pull request
Jan 29, 2024
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]>
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Mar 28, 2024
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit 2b97bea)
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Mar 28, 2024
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit 2b97bea)
martinkennelly
added a commit
to martinkennelly/ovn-kubernetes
that referenced
this pull request
Apr 8, 2024
Netlink lib merged their default route fix [1]. The issue was the lib represented an 'any' route (aka 0.0.0.0/0 for v4) as dst = nil. If a user wanted to set an any route, they must explicitly set dst not nil. Therefore looking at a system and looking at what the user wanted for any routes added extra complexity. Upgrade the pkg to remove that complexity. [1] vishvananda/netlink#852 Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit 2b97bea)
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Aug 26, 2024
There seems to be one change[1] which breaks our tests, the route Dst field is no longer nil for a default route but rather the empty ipnet, i.e. 0.0.0.0/0 and ::/0 so fix that up in our code. [1] vishvananda/netlink#852 Signed-off-by: Paul Holzinger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #670 && #611 are both introduced by "default" route.
There is indeed no attribute tlv encoded for RTA_DST while doing RTM_GETROUTE requests, but while we doing ADD/DELETE opearation, we do need encode such "default" dst (i.e., 0.0.0.0/0 or ::/0).
This introduced the inconsistence between "read" and "write" and lead failure for flushing the route table(deleting all routes from what listed)
Refer to iproute2 implementation, add the same logic for
deserializeRoute