Merged
Conversation
sargun
approved these changes
Jun 13, 2019
Owner
|
This lgtm. @aboch any reason we shouldn't merge this. Seems like merging and then shipping a 1.1.0 release that supports modules is a good idea. |
thaJeztah
approved these changes
Oct 6, 2019
Contributor
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, but left a suggestion
go.mod
Outdated
| go 1.12 | ||
|
|
||
| require ( | ||
| github.com/vishvananda/netns v0.0.0-20180720170159-13995c7128cc |
Contributor
There was a problem hiding this comment.
If this PR looks good to you @vishvananda @aboch, it's probably nice to have vishvananda/netns#35 merged before this one (and, if possible, tag a release for https://github.com/vishvananda/netns)
Collaborator
There was a problem hiding this comment.
@tklauser the netns PR is merged. You may want to update this reference then.
Contributor
Author
|
Ping? |
Contributor
|
@aboch ping |
Collaborator
|
LGTM |
Signed-off-by: Tobias Klauser <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tobias Klauser [email protected]