added encapsulation attributes for Iptun and Sittun to support SIT tunnels#281
Merged
vishvananda merged 1 commit intovishvananda:masterfrom Oct 26, 2017
Merged
added encapsulation attributes for Iptun and Sittun to support SIT tunnels#281vishvananda merged 1 commit intovishvananda:masterfrom
vishvananda merged 1 commit intovishvananda:masterfrom
Conversation
Contributor
Author
|
For this project I'm doing I would like SIT tunnel support in this library as well. Since these links are similar to |
skoef
changed the title
Owner
|
This looks reasonable. Can you squash it down into a single commit? Thanks |
added encapsulation attributes to Gretun implemented Sittun struct for supporting SIT tunnels
Contributor
Author
|
I thought github featured a squash&merge button, nevertheless: it's squashed, no problem! |
Owner
|
it does support squash and merge, but I prefer rebase and merge to keep a linear commit tree. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Iptunstruct didn't support encapsulation attributes like source or destination port yet, whileGretapdid and the feature appeared for both interface types around the same time. I basically copied the parsing and adding of the attributes fromGretaptoIptunand it seems to work fine.