Skip to content

Add support for managing source MACVLANs#260

Closed
lukegb wants to merge 1 commit intovishvananda:masterfrom
lukegb:macvlan-source
Closed

Add support for managing source MACVLANs#260
lukegb wants to merge 1 commit intovishvananda:masterfrom
lukegb:macvlan-source

Conversation

@lukegb
Copy link
Contributor

@lukegb lukegb commented Aug 21, 2017

Add MacvlanMACAddrAdd, MacvlanMACAddrDel, MacvlanMACAddrSet and MacvlanMACAddrFlush for managing the MAC addresses associated with a source-type macvlan interface.

Populates a MACAddrs field on Macvlan if the information is provided by Netlink.

@vishvananda
Copy link
Owner

This looks reasonable. Is there a reason it is still marked WIP?

@aboch
Copy link
Collaborator

aboch commented Nov 10, 2017

ping @lukegb

Is it still WIP ?

@lukegb lukegb changed the title WIP: Add support for managing source MACVLANs Add support for managing source MACVLANs Nov 10, 2017
@lukegb
Copy link
Contributor Author

lukegb commented Nov 10, 2017

This should work - I'm not using it anymore myself, but it should be good to go.

@aboch
Copy link
Collaborator

aboch commented Nov 10, 2017

Thanks @lukegb. Please replace syscall with unix pkg and sign your commit.

@aboch
Copy link
Collaborator

aboch commented Nov 27, 2017

@lukegb. Please replace syscall with unix pkg (See #286) and sign your commit.

@aboch
Copy link
Collaborator

aboch commented Nov 28, 2017

Thanks @lukegb I carried over your commit + requested changes in #303

@aboch aboch closed this in #303 Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants