Skip to content

Support num{tx,rx}queues and udp6zerocsum{tx,rx}#225

Merged
aboch merged 1 commit intovishvananda:masterfrom
s1061123:add_vxlan_attr2
Nov 14, 2017
Merged

Support num{tx,rx}queues and udp6zerocsum{tx,rx}#225
aboch merged 1 commit intovishvananda:masterfrom
s1061123:add_vxlan_attr2

Conversation

@s1061123
Copy link
Contributor

Add IFLA_NUM_TX_QUEUES and IFLA_NUM_RX_QUEUES in link attribute and
IFLA_VXLAN_UDP_ZERO_CSUM6_TX and IFLA_VXLAN_UDP_ZERO_CSUM6_RX in VXLAN
attribute.

@vishvananda
Copy link
Owner

This looks correct. I think you also need to parse the values during link list? A test would also be helpful to ensure that the values are getting set correctly.

@s1061123
Copy link
Contributor Author

Thank you for your review! Let me add parase and test and update it.

@s1061123
Copy link
Contributor Author

In my host, TestLinkAddDelVxlan is passed, but TravisCI makes it failed and now I am troubleshooting on it.

=== RUN TestLinkAddDelVxlan
--- PASS: TestLinkAddDelVxlan (0.03s)

@aboch
Copy link
Collaborator

aboch commented Nov 10, 2017

@s1061123 Please rebase to latest, resolve the conflict, squash the commits in one and add the minKernelRequired(t, N, M) call before the new tests, as I see IFLA_VXLAN_UDP_ZERO_CSUM6_TX is not present in kernel 3.10 for example. Maybe add a dedicated test function for IFLA_VXLAN_UDP_ZERO_CSUM6_TX/RX flags so that only will be skipped on older kernels.

@s1061123
Copy link
Contributor Author

Thank you for your info, @aboch !
I will do that in a few days.

@s1061123
Copy link
Contributor Author

s1061123 commented Nov 13, 2017

Update the diffs with merge to latest.

@aboch
Copy link
Collaborator

aboch commented Nov 13, 2017

@s1061123 Please rebase again and squash the commits into one before pushing.

Add IFLA_NUM_TX_QUEUES and IFLA_NUM_RX_QUEUES in link attribute and
IFLA_VXLAN_UDP_ZERO_CSUM6_TX and IFLA_VXLAN_UDP_ZERO_CSUM6_RX in VXLAN
attribute.
@s1061123
Copy link
Contributor Author

@aboch thank you for your advice! I've squashed into one commit.

@aboch
Copy link
Collaborator

aboch commented Nov 14, 2017

Thank you @s1061123. LGTM

@aboch aboch merged commit e104583 into vishvananda:master Nov 14, 2017
@s1061123 s1061123 deleted the add_vxlan_attr2 branch November 14, 2017 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants