Repository navigation
Conversation
6 tasks done
Member
Author
|
superseded by #87 |
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TruncateCodecto handle edge strips that are padded to full size on diskDetails
Previously, strip-based TIFFs with partial final strips (e.g., 100px height with 30px rows-per-strip) raised a
ValueErrorbecause zarr's regular chunk grid requires uniform chunk sizes. This PR uses rectilinear chunk grids instead, allowing the final strip to have a different size.Key changes:
parser.py:_get_chunks_from_stripsnow returns a nested sequence (e.g.,[[30, 30, 30, 10], [width]]) for non-uniform strips instead of raising._construct_manifest_arrayselects betweenregularandrectilinearchunk grids accordingly.codecs.py: NewTruncateCodec(bytes-to-bytes) trims oversized edge-chunk buffers to their expected logical size before downstream codecs process them.utils.py: Added_is_nested_sequencehelper (vendored from zarr-python#3534) to distinguish rectilinear chunk specs from regular ones.test_gdal_examples.py: Removed the entirepartial_chunksxfail list (~30 files). Moved a few files back into their correct category lists (jpeg_tables, YCbCr).Dependencies
Requires upstream rectilinear chunk grid support in zarr-python, VirtualiZarr, and xarray (see
pyproject.tomlfor feature branches).