Skip to content

Comments

feat: add isBlobUrl parameter to GM_getResourceURL#1438

Merged
tophf merged 2 commits intoviolentmonkey:masterfrom
tophf:gmgru-type
Dec 11, 2021
Merged

feat: add isBlobUrl parameter to GM_getResourceURL#1438
tophf merged 2 commits intoviolentmonkey:masterfrom
tophf:gmgru-type

Conversation

@tophf
Copy link
Member

@tophf tophf commented Dec 10, 2021

GM_getResourceURL(name) // blob: URL
GM_getResourceURL(name, true) // blob: URL
GM_getResourceURL(name, false) // data: URL

@tophf tophf requested a review from gera2ld December 10, 2021 16:51
@tophf tophf changed the title feat: add type parameter to GM_getResourceURL feat: add isBlobUrl parameter to GM_getResourceURL Dec 11, 2021
GM_getResourceURL(name) // blob: URL
GM_getResourceURL(name, true) // blob: URL
GM_getResourceURL(name, false) // data: URL
@tophf
Copy link
Member Author

tophf commented Dec 11, 2021

I've simplified the PR: the second parameter is a boolean now, true (default) is a blob URL, otherwise it's a data URL.

Copy link
Member

@gera2ld gera2ld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tophf tophf merged commit 8cfa224 into violentmonkey:master Dec 11, 2021
@tophf tophf deleted the gmgru-type branch December 11, 2021 09:45
@lisonge
Copy link

lisonge commented Sep 14, 2022

isBlobUrl not work
image

@tophf
Copy link
Member Author

tophf commented Sep 14, 2022

@lisonge, it works since Violentmonkey v2.13.0.15, so you're probably using an old version. See beta.

@lisonge
Copy link

lisonge commented Sep 14, 2022

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants