Replacing our Tus upload integration with TusPHP.#186
Merged
Conversation
erunion
changed the title
Onebrownsound
approved these changes
Nov 15, 2018
Onebrownsound
left a comment
Onebrownsound
left a comment
There was a problem hiding this comment.
LGTM. Nice to see parity between the SDKs. One minor comment, but other than that gj!
| 'Upload-Offset: {placeholder}', | ||
| ) | ||
| ); | ||
| $base_url = str_replace($url_path, '', $url); |
There was a problem hiding this comment.
This is okay for now, imo. But maybe mark this as a #TODO to export into it's own static function that takes in the path and returns all the necessary pieces, as a list or something. For testability and such.
|
I'm using PHP 7.2 and Vimeo 3.0 but I can't upload big files using tus approach (PATCH). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, I was able to upload video files that ranged from 13-793MB large. Since the default PHP memory limit is 128MB, we're uploading in 100MB chunks, so anything larger than what I've tested with should function just as well.
Since this is a breaking change, this'll be tagged released as v3.0.
Resolves #168