Skip to content

[TASK] Enrich taint details for outputting core stubs#5827

Merged
muglug merged 1 commit intovimeo:masterfrom
ohader:outputting-stubs
May 24, 2021
Merged

[TASK] Enrich taint details for outputting core stubs#5827
muglug merged 1 commit intovimeo:masterfrom
ohader:outputting-stubs

Conversation

@ohader
Copy link
Contributor

@ohader ohader commented May 24, 2021

Affects taint behavior or PHP core functions printf, print_r, var_dump, var_export.
This change does not change nor introduce conditional taint sinks as discussed in issue #4669.

Affects `printf`, `print_r`, `var_dump`, `var_export`
@muglug muglug merged commit 4898cd2 into vimeo:master May 24, 2021
@muglug
Copy link
Collaborator

muglug commented May 24, 2021

Thanks!

@ohader ohader deleted the outputting-stubs branch May 24, 2021 20:59
ohader added a commit to ohader/psalm that referenced this pull request May 26, 2021
Affects `printf`, `print_r`, `var_dump`, `var_export`
*
* @psalm-taint-specialize
* @psalm-flow ($var) -> return
* @psalm-taint-sink html $var
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #3744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants