Add dedicated types for 'file', 'header' and 'cookie' #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasReschke
commented
Nov 19, 2020
| 'fopen' => [['shell']], | ||
| 'header' => [['text']], | ||
| 'file_get_contents' => [['file']], | ||
| 'file_put_contents' => [['file']], |
There was a problem hiding this comment.
Technically that could also be used for RCE (by writing a file somewhere in the web root).
I'll make sure to document the different risks in the documentation for the file type. In the future we could consider having separate types that all potentially share similar sanitizers though.
LukasReschke
changed the title
LukasReschke
changed the title
2 tasks
|
Thanks! |
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* [WIP] Add dedicated sinks for 'file', 'header' and 'cookie' * Add documentation * Add mapping for taint flows * Add tests * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates the three new dedicated rules and the responding documentation:
For the
filetype, this change also adds more sinks.Fixes #4596