Fix array_reverse type for list{0: int, 1?: int} etc.#11150
Merged
orklah merged 3 commits intoFeb 21, 2025
Merged
Conversation
MoonE
force-pushed
the
fix-array-reverse-of-list--with-possibly-undefined-values
branch
from
November 10, 2024 17:18
c297b4c to
dca758d
Compare
Collaborator
|
Please rebase on 6.x so we can merge it :) |
MoonE
force-pushed
the
fix-array-reverse-of-list--with-possibly-undefined-values
branch
from
February 16, 2025 19:13
dca758d to
713c1d1
Compare
orklah
added
the
release:fix
Collaborator
|
Thanks! |
MoonE
deleted the
fix-array-reverse-of-list--with-possibly-undefined-values
branch
February 21, 2025 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11148
I'm not entirely sure if
$first_arg_array->propertiescan have string keys? The type suggests it but not sure if it is possible here, because currently those would be lost with my implementation.