Merge pull request #9761 from Alkisum/removed-return-type-false-from-date-and-gmdate

orklah · web-flow · commit 841cccd693a1 · 2023-05-09T19:57:01.000+02:00
Removed return type false from date and gmdate
diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/DateReturnTypeProvider.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/DateReturnTypeProvider.php
@@ -64,6 +64,6 @@ public static function getFunctionReturnType(FunctionReturnTypeProviderEvent $ev
                 return $format_type;
             }
         }
-        return Type::combineUnionTypes($format_type, Type::getFalse());
+        return $format_type;
     }
 }
diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -1791,14 +1791,14 @@ function test() : void {
                     '$F===' => 'string',
                     '$y2===' => 'numeric-string',
                     '$F2===' => 'string',
-                    '$F3===' => 'false|string',
+                    '$F3===' => 'string',
                     '$gm_y===' => 'numeric-string',
                     '$gm_ym===' => 'numeric-string',
                     '$gm_m===' => 'numeric-string',
                     '$gm_F===' => 'string',
                     '$gm_y2===' => 'numeric-string',
                     '$gm_F2===' => 'string',
-                    '$gm_F3===' => 'false|string',
+                    '$gm_F3===' => 'string',
                 ],
             ],
             'sscanfReturnTypeWithTwoParameters' => [

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,6 @@ public static function getFunctionReturnType(FunctionReturnTypeProviderEvent $ev`
`64`	`64`	`return $format_type;`
`65`	`65`	`}`
`66`	`66`	`}`
`67`		`- return Type::combineUnionTypes($format_type, Type::getFalse());`
	`67`	`+ return $format_type;`
`68`	`68`	`}`
`69`	`69`	`}`