Merge pull request #8436 from TimWolla/attribute-target

AndrolGenhald · web-flow · commit 2fdcd5a5fc48 · 2022-08-24T16:59:40.000-05:00
Configure a correct attribute target in stubs/CoreGenericClasses.phpstub
diff --git a/stubs/CoreGenericClasses.phpstub b/stubs/CoreGenericClasses.phpstub
@@ -496,19 +496,19 @@ final class WeakMap implements ArrayAccess, Countable, IteratorAggregate, Traver
 }
 
 
-#[Attribute]
+#[Attribute(Attribute::TARGET_METHOD)]
 final class ReturnTypeWillChange
 {
     public function __construct() {}
 }
 
-#[Attribute]
+#[Attribute(Attribute::TARGET_PARAMETER)]
 final class SensitiveParameter
 {
     public function __construct() {}
 }
 
-#[Attribute]
+#[Attribute(Attribute::TARGET_CLASS)]
 final class AllowDynamicProperties
 {
     public function __construct() {}
diff --git a/tests/AttributeTest.php b/tests/AttributeTest.php
@@ -787,6 +787,22 @@ public function anotherMethod(): string
                 false,
                 '8.1',
             ],
+            'sensitiveParameterOnMethod' => [
+                '<?php
+
+                    namespace SensitiveParameter;
+
+                    use SensitiveParameter;
+
+                    class HelloWorld {
+                        #[SensitiveParameter]
+                        public function __construct(
+                            string $password
+                        ) {}
+                    }
+                ',
+                'error_message' => 'Attribute SensitiveParameter cannot be used on a method',
+            ],
         ];
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -496,19 +496,19 @@ final class WeakMap implements ArrayAccess, Countable, IteratorAggregate, Traver`
`496`	`496`	`}`
`497`	`497`
`498`	`498`
`499`		`-#[Attribute]`
	`499`	`+#[Attribute(Attribute::TARGET_METHOD)]`
`500`	`500`	`final class ReturnTypeWillChange`
`501`	`501`	`{`
`502`	`502`	`public function __construct() {}`
`503`	`503`	`}`
`504`	`504`
`505`		`-#[Attribute]`
	`505`	`+#[Attribute(Attribute::TARGET_PARAMETER)]`
`506`	`506`	`final class SensitiveParameter`
`507`	`507`	`{`
`508`	`508`	`public function __construct() {}`
`509`	`509`	`}`
`510`	`510`
`511`		`-#[Attribute]`
	`511`	`+#[Attribute(Attribute::TARGET_CLASS)]`
`512`	`512`	`final class AllowDynamicProperties`
`513`	`513`	`{`
`514`	`514`	`public function __construct() {}`