Fix memory leak in eval_dict() in src/dict.c#19531
Closed
huanghuihui0904 wants to merge 1 commit intovim:masterfrom
Closed
Fix memory leak in eval_dict() in src/dict.c#19531huanghuihui0904 wants to merge 1 commit intovim:masterfrom
eval_dict() in src/dict.c#19531huanghuihui0904 wants to merge 1 commit intovim:masterfrom
Conversation
Signed-off-by: huanghuihui0904 <[email protected]>
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
eval_dict(), the dictionarydis allocated whenevaluateis true (lines 958–963):Later, when parsing a Vim9 dictionary key written in bracket form (
[key]), the code reports an error if the closing]is missing and returns early (lines 993–998):Returning directly bypasses the shared cleanup in the
failret:block, wheredis freed. This results in a memory leak on this error path.Solution
Replace the direct
return FAIL;withgoto failret;so that the existing cleanup logic is executed. The fix is included in this commit.