Closed
Conversation
luukvbaal
force-pushed
the
spellsuggest
branch
from
f82bcf5 to
b86e3ab
Compare
Member
|
Thanks, but what is the reason to introduce a new local variable curline? Oh and it breaks an existing test? |
Problem: When z= fails due to no word being found, 'spelllang' being
unset or a multiline visual selection, 'nospell' is not
restored.
Solution: Jump to where the user configured value of 'spell' is restored
instead of returning early.
Contributor
Author
|
Introduced The failing test relies on "z=" setting 'spell', updated to set it explicitly. |
luukvbaal
force-pushed
the
spellsuggest
branch
from
b86e3ab to
1cc141a
Compare
Member
|
Ah that makes sense. Thanks |
luukvbaal
added a commit
to luukvbaal/neovim
that referenced
this pull request
Feb 28, 2026
Problem: When z= fails due to no word being found, 'spelllang' being
unset or a multiline visual selection, 'nospell' is not
restored.
Solution: Jump to where the user configured value of 'spell' is restored
instead of returning early (Luuk van Baal).
closes: vim/vim#19525
vim/vim@eba078f
luukvbaal
added a commit
to luukvbaal/neovim
that referenced
this pull request
Feb 28, 2026
Problem: When z= fails due to no word being found, 'spelllang' being
unset or a multiline visual selection, 'nospell' is not
restored.
Solution: Jump to where the user configured value of 'spell' is restored
instead of returning early (Luuk van Baal).
closes: vim/vim#19525
vim/vim@eba078f
luukvbaal
added a commit
to neovim/neovim
that referenced
this pull request
Mar 1, 2026
) Problem: When z= fails due to no word being found, 'spelllang' being unset or a multiline visual selection, 'nospell' is not restored. Solution: Jump to where the user configured value of 'spell' is restored instead of returning early (Luuk van Baal). closes: vim/vim#19525 vim/vim@eba078f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When z= fails due to no word being found, 'spelllang' being
unset or a multiline visual selection, 'nospell' is not
restored.
Solution: Jump to where the user configured value of 'spell' is restored
instead of returning early.
Ref neovim/neovim#38094