feat(session): added SessionLoadPre#19306
Closed
ColinKennedy wants to merge 1 commit intovim:masterfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a new SessionLoadPre autocmd event that fires before a session file begins loading, complementing the existing SessionLoadPost event.
Changes:
- Added
EVENT_SESSIONLOADPREenum value and corresponding event name mapping - Modified session file generation to trigger
SessionLoadPreautocmd after settingv:this_session - Added comprehensive test coverage verifying the event fires before session variables are set
- Updated documentation across multiple files to describe the new autocmd event
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vim.h | Adds EVENT_SESSIONLOADPRE enum constant for the new autocmd event |
| src/autocmd.c | Registers the "SessionLoadPre" event name in the event lookup table |
| src/session.c | Inserts doautoall SessionLoadPre command in generated session files |
| src/testdir/test_autocmd.vim | Adds test verifying SessionLoadPre fires before SessionLoadPost and session variables are set |
| runtime/doc/autocmd.txt | Documents the new SessionLoadPre autocmd event with its trigger condition |
| runtime/doc/starting.txt | Updates session loading documentation to mention SessionLoadPre |
| runtime/doc/options.txt | Adds SessionLoadPre to the alphabetical list of autocmd events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| only | ||
| endfunc | ||
|
|
||
| func Test_autocmd_SessLoadPre() |
There was a problem hiding this comment.
Function name uses abbreviated 'Sess' instead of 'Session' which is inconsistent with the actual autocmd event name 'SessionLoadPre'. Consider renaming to 'Test_autocmd_SessionLoadPre' for clarity and consistency.
Suggested change
| func Test_autocmd_SessLoadPre() | |
| func Test_autocmd_SessionLoadPre() |
| [CODE] | ||
|
|
||
| call writefile(content, 'Xvimrc', 'D') | ||
|
|
There was a problem hiding this comment.
The filename 'Sessionx.vim' is unclear. The 'x' suffix doesn't convey its purpose (appending session variables). Consider a more descriptive name like 'SessionAppend.vim' or add a comment explaining why this separate file is needed.
Suggested change
| " Write extra session settings to a separate file that will be sourced | |
| " in addition to Session.vim (to append session variables for this test). |
Member
|
thanks |
Contributor
Author
|
Thank you!! |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Feb 26, 2026
Problem: Not possible to know when a session will be loaded. Solution: Add the SessionLoadPre autocommand (Colin Kennedy). fixes: vim/vim#19084 closes: vim/vim#19306 vim/vim@1c0d468 Co-authored-by: Colin Kennedy <[email protected]>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Feb 26, 2026
Problem: Not possible to know when a session will be loaded. Solution: Add the SessionLoadPre autocommand (Colin Kennedy). fixes: vim/vim#19084 closes: vim/vim#19306 vim/vim@1c0d468 Co-authored-by: Colin Kennedy <[email protected]>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Feb 26, 2026
#38071) Problem: Not possible to know when a session will be loaded. Solution: Add the SessionLoadPre autocommand (Colin Kennedy). fixes: vim/vim#19084 closes: vim/vim#19306 vim/vim@1c0d468 Co-authored-by: Colin Kennedy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19084
A new
SessionLoadPreautocmd is defined and theSession.vimcalls it before attempting to do any work.SessionLoadPrehas access tov:this_session.This is a followup from #19151, sorry for the spam