Skip to content

[RFC] runtime/helptoc: uncache g:helptoc.shell_prompt #16097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benknoble wants to merge 2 commits into from
Closed

[RFC] runtime/helptoc: uncache g:helptoc.shell_prompt #16097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a4c86
runtime/helptoc: reload cached g:helptoc.shell_prompt when starting toc
benknoble Nov 21, 2024
bad2ea9
make changes to user settings invalidate the cache
benknoble Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions runtime/pack/dist/opt/helptoc/autoload/helptoc.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,20 @@ vim9script noclear

# Config {{{1

const SHELL_PROMPT: string = g:
->get('helptoc', {})
->get('shell_prompt', '^\w\+@\w\+:\f\+\$\s')
var SHELL_PROMPT: string = ''

def UpdateUserSettings() #{{{2
var new_prompt: string = g:
->get('helptoc', {})
->get('shell_prompt', '^\w\+@\w\+:\f\+\$\s')
if new_prompt != SHELL_PROMPT
SHELL_PROMPT = new_prompt
# invalidate cache: user config has changed
unlet! b:toc
endif
enddef

UpdateUserSettings()

# Init {{{1

Expand Down Expand Up @@ -141,6 +152,8 @@ export def Open() #{{{2
return
endif

UpdateUserSettings()

# invalidate the cache if the buffer's contents has changed
if exists('b:toc') && &filetype != 'man'
if b:toc.changedtick != b:changedtick
Expand Down
Loading