You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 80d00ab
Browse filesBrowse the repository at this point in the historyBrowse files
feat(rust): admit cross-crate workspace CALLS behind the fail-closed predicate
Land the first admission class of the per-class recovery plan (ISSUES.md
root-cause section 6, docs/RUST_CODEGRAPH_TRUTH_PLAN.md): exact,
source-site-matched ::-qualified calls whose callee the resolver routed
uniquely into a declared Cargo workspace member.
Admission boundary, argued from the predicate's inputs:
- strategy "lsp_cross_crate" has exactly one emission site
(internal/cbm/lsp/rust_lsp.c block DeusData#56), whose guards are the class
guarantee: a parsed Cargo manifest, the call path head declared as a
workspace member, and exactly one registered free function in that member
matching the call tail; two candidates emit nothing (mem_matches < 2
cutoff). The callee QN is the registry entry's qualified_name, never a
synthesized name. Name-guess and registry fallbacks emit other strategies
and stay rejected; Rust never falls through to textual resolution
(pass_calls.c returns before the registry for CBM_LANG_RUST).
- The predicate re-derives the member linkage from its own inputs: the
carrier's callee text must be ::-qualified with a non-empty head, and the
resolved QN must pass through the ".<head>." segment
(cbm_pipeline_qn_has_dotted_segment) — the same needle the resolver used —
so a mis-joined resolution row for a different crate cannot claim the
class. Same-named decoys in another member fail the segment check
(demonstrated by the pinned test's crates/beta/src/local.rs decoys, which
get zero edges).
- The resolved callee must lie outside the caller's file module, keeping
this class strictly cross-crate and disjoint from the plain class.
- Floor shared with the plain class, now hoisted: real parsed call site
(!requires_lsp_resolution), caller is this file's single-segment free
function, and occurrence-exact source-site join (byte-span + origin).
Semantic epoch moves with the class: 8 -> 9 in src/store/store.h and
tests/semantic-epoch.expected in this same commit (Step 0y contract).
docs/RUST_CODEGRAPH_TRUTH_PLAN.md gains the class in Supported behavior;
the not-restored list narrows to import-mediated cross-file calls.
tests/fixtures/scip_harness/expected.txt is deliberately unchanged: the
harness corpus's only cross-crate call (beta total -> alpha add) is
import-mediated (use alpha::add; bare add(1,2)), which never reaches the
::-gated resolver block, so the graph side of the join is identical.
New-helper existence check (coding standards): codebase-memory search_graph
query "dotted qualified name segment contains substring match", 15 hits
inspected; contains_segment (internal/cbm/service_patterns.c:562) is
'/'-separated and static to its module, qualified_suffix_match
(src/pipeline/registry.c:887) is tail-anchored and static; neither expresses
an interior dotted-segment match, so cbm_pipeline_qn_has_dotted_segment is
added beside its only caller in lsp_resolve.h.
Pinned by pipeline_rust_cargo_manifest_converges_across_routes (all three
routes) and the two cargo-route mutation rows, which become live and KILLED
with this class.
The two issue-56 provenance tests (tests/test_parallel.c) pinned the
pre-class refusal: even the correct .crate_a. candidate had to stay out
while workspace provenance was untrusted. This class is exactly that trust
landing, so they flip to positive exact-target controls alongside the
retained decoy refusals (unlisted member, local shadow) and are renamed to
state the new behavior:
- parallel_rust_workspace_manifest_routes_call_to_declared_member_only
- parallel_rust_local_shadow_loses_to_workspace_manifest_provenance
Their executed discriminator is the pre-class run of this same tree, where
desired_candidate was false on both (observed red before this commit);
the decoy refusals stayed green throughout.
0 commit comments