Skip to content

Add integration tests for XCFramework support#1

Merged
vikrem merged 2 commits into
vikrem:vikrem.feature/xcframeworksfrom
mpdifran:mark.integrationTests
Oct 29, 2021
Merged

Add integration tests for XCFramework support#1
vikrem merged 2 commits into
vikrem:vikrem.feature/xcframeworksfrom
mpdifran:mark.integrationTests

Conversation

@mpdifran

Copy link
Copy Markdown
  • Looks like BCSymbolMaps and dSYMs are actually stored inside the XCFramework itself, so the tests are much more straightforward.
  • I ran Rome with --use-xcframeworks and it looks like the .*.version weren't copied back into the Carthage/Build folder. Not sure if that's a mistake on my system or if there's something missing in the command.

@mpdifran mpdifran changed the title Add integration tests for XCFramrwork support Add integration tests for XCFramework support Oct 18, 2021
@mpdifran

Copy link
Copy Markdown
Author

@tmspzz I'm having trouble getting bats setup to run the tests, but I believe they should work. Are you able to verify them locally? Once that's done, we can merge this into @vikrem's PR and merge that into Rome.

@ivanrein

Copy link
Copy Markdown

I also tried using it with aws, for me it uploaded and downloaded version files, but I got another errors about not finding dSYM files
I just posted it in the other PR
tmspzz#247 (comment)

@tmspzz

tmspzz commented Oct 20, 2021

Copy link
Copy Markdown

error == cache miss

Not really an error

@tmspzz

tmspzz commented Oct 20, 2021

Copy link
Copy Markdown

@mpdifran

I am impressed this works with .ini as well. 🤯

This is great work!

One thing that is missing tho is testing for the current framework. Or did I miss it while reviewing 🤔

@mpdifran

Copy link
Copy Markdown
Author

@tmspzz You're right, I missed that case. Added another test suite for the current framework.

@mpdifran

Copy link
Copy Markdown
Author

@tmspzz mind giving it another look? I think we're good to go!

@tmspzz

tmspzz commented Oct 28, 2021

Copy link
Copy Markdown

@mpdifran @vikrem LGTM. However however why are the .version files missing 👀 ?

@vikrem

vikrem commented Oct 29, 2021

Copy link
Copy Markdown
Owner

sorry for the delay here, been quite busy with some other things.

@tmspzz i'm going to merge in @mpdifran's work here into this branch, and i'll continue getting this in proper shape for merging into rome over in tmspzz#247

@vikrem vikrem merged commit 0cd86b4 into vikrem:vikrem.feature/xcframeworks Oct 29, 2021
@mpdifran mpdifran deleted the mark.integrationTests branch October 29, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants