Repository navigation
Commit be1b2e5
feat: support regular BuildRight+LeftAnti hash join
DataFusion HashJoinExec supports LeftAnti in all build-side configurations,
and the planner's existing swap_inputs logic handles BuildRight correctly.
The original guard in operators.scala was added without a stated reason;
the referenced issue apache#457 was specifically about null-aware anti-join
(fixed via DataFusion 53), not regular BuildRight+LeftAnti.
Changes:
- Remove the BuildRight+LeftAnti rejection in CometHashJoin
- Allow SortMergeJoin+BuildRight+LeftAnti to be rewritten to ShuffledHashJoin
- Re-enable the previously-disabled SHJ BuildRight+LeftAnti test
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>1 parent fe3e019 commit be1b2e5
3 files changed
Lines changed: 5 additions & 16 deletions
File tree
- spark/src
- main/scala/org/apache
- comet/rules
- spark/sql/comet
- test/scala/org/apache/comet/exec
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
| 70 | + | |
72 | 71 | | |
73 | 72 | | |
74 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1710 | 1710 | | |
1711 | 1711 | | |
1712 | 1712 | | |
1713 | | - | |
1714 | | - | |
1715 | | - | |
| 1713 | + | |
1716 | 1714 | | |
1717 | 1715 | | |
1718 | 1716 | | |
1719 | 1717 | | |
1720 | 1718 | | |
1721 | | - | |
1722 | | - | |
1723 | | - | |
1724 | | - | |
1725 | | - | |
1726 | | - | |
1727 | | - | |
1728 | | - | |
1729 | 1719 | | |
1730 | 1720 | | |
1731 | 1721 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
194 | | - | |
| 193 | + | |
| 194 | + | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| |||
0 commit comments